DynamicItemDescriptions Review #79
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "DynamicItemDescriptions"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
To fix up Issue #76
Tests still need to be written to validate the tooltip names and descriptions work and continue to function as expected in the future.
@ -98,1 +98,4 @@const std::string&GetName()const;const std::string_view GetDescription()const;const std::string GetNameWithPlayerModifiers()const;Add test for this new function.
Resolved in commit
fab7f34afa@ -98,1 +99,4 @@const std::string_view GetDescription()const;const std::string GetNameWithPlayerModifiers()const;const std::string GetDescriptionWithPlayerModifiers()const;Add test for this new function.
Resolved in commit
fab7f34afa@ -63,4 +64,7 @@ namespace classutils{//Classes have bit-wise operator capabilities.int element=int(std::distance(classList.begin(),it));return Class(1<<element); //Yes...It's bitwise flags, who in god's name knows why I did this.};static inline std::string ClassToString(const Class&cl){Add test for this new function.
Test added in commit
bee8d6d306@ -81,2 +90,3 @@const float GetConfigValue(const std::string_view keyName)const;const float GetConfigValue(const std::string_view keyName)const;const float operator[](const std::string&name)const;const AbilityDescriptionModifiers GetModifiers()const;Add test for this new function.
Resolved in commit
67ca0d168d@ -82,1 +90,4 @@const float GetConfigValue(const std::string_view keyName)const;const float operator[](const std::string&name)const;const AbilityDescriptionModifiers GetModifiers()const;static const std::vector<std::reference_wrapper<ItemEnchantInfo>>GetAllEnchantsAffectingAbility(const std::string_view ability);Add test for this new function.
Added in commit
2fea77c66c@ -340,6 +340,7 @@ public:void SetTestScreenAimingLocation(vf2d forcedAimingLoc);const bool CoveredInInk()const;const vf2d&GetPreviousPos()const; //The position the player was at on the last frame, can be used for comparison purposes to predict where the player may be next.const std::unordered_set<std::string>&GetEnchants()const; //Get all enchants currently affeting the player.Typo here in the comment.
Fixed in commit
f962e90cad@ -25,0 +25,4 @@Silly Large Purple Wizard CloakPeace sign on finishing a stage (wink)Kitty HeadbandAdd zombie heart eyes idea.
Fixed in commit
f962e90cadWIP: DynamicItemDescriptions Reviewto DynamicItemDescriptions Review