DynamicItemDescriptions Review #79

Merged
sigonasr2 merged 28 commits from DynamicItemDescriptions into master 2025-05-15 11:12:36 -05:00
Owner

To fix up Issue #76

To fix up Issue #76
sigonasr2 added 20 commits 2025-05-12 19:26:10 -05:00
Add in Gitea workflow for remote auto-build.
Some checks failed
Emscripten Build / Build_and_Deploy_Web_Build (push) Has been cancelled
5a4e7fb53b
Build should be multi-threaded.
Some checks failed
Emscripten Build / Build_and_Deploy_Web_Build (push) Failing after 1m18s
8d8534c90b
Add multiple threads to autobuild.
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 6m45s
0f012faf36
Setting up for revealing modified descriptions and names all put together.
Some checks failed
Emscripten Build / Build_and_Deploy_Web_Build (push) Failing after 1m44s
9722695e5b
Add changes to parse enchants affecting abilities.
Some checks failed
Emscripten Build / Build_and_Deploy_Web_Build (push) Failing after 1m31s
dcb31a01e1
Fixed constness of std::vector<std::reference_wrapper<const ItemEnchantInfo>> for GetAllEnchantsAffectingAbility() function.
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 7m8s
8c8567017c
Fix name and description displays for abilities on hover. Release Build 12161.
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 6m51s
62ef4d2815
Create variable parser. Need to fix up when it parses the name and description and all references for its arguments.
Some checks failed
Emscripten Build / Build_and_Deploy_Web_Build (push) Failing after 1m25s
93298e05d3
Fix parsing of ability descriptions to use owning strings and to retrieve from the proper keys. (Except for non-enchants.)
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 7m47s
cb3f38e07c
sigonasr2 added 1 commit 2025-05-12 19:26:23 -05:00
Merge branch 'master' into DynamicItemDescriptions
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 7m13s
ae6e5af5f6
Author
Owner

Tests still need to be written to validate the tooltip names and descriptions work and continue to function as expected in the future.

Tests still need to be written to validate the tooltip names and descriptions work and continue to function as expected in the future.
sigonasr2 reviewed 2025-05-13 16:42:09 -05:00
@ -98,1 +98,4 @@
const std::string&GetName()const;
const std::string_view GetDescription()const;
const std::string GetNameWithPlayerModifiers()const;
Author
Owner

Add test for this new function.

Add test for this new function.
Author
Owner

Resolved in commit fab7f34afa

Resolved in commit fab7f34afa
sigonasr2 marked this conversation as resolved
sigonasr2 reviewed 2025-05-13 16:42:14 -05:00
@ -98,1 +99,4 @@
const std::string_view GetDescription()const;
const std::string GetNameWithPlayerModifiers()const;
const std::string GetDescriptionWithPlayerModifiers()const;
Author
Owner

Add test for this new function.

Add test for this new function.
Author
Owner

Resolved in commit fab7f34afa

Resolved in commit fab7f34afa
sigonasr2 marked this conversation as resolved
sigonasr2 reviewed 2025-05-13 16:42:35 -05:00
@ -63,4 +64,7 @@ namespace classutils{//Classes have bit-wise operator capabilities.
int element=int(std::distance(classList.begin(),it));
return Class(1<<element); //Yes...It's bitwise flags, who in god's name knows why I did this.
};
static inline std::string ClassToString(const Class&cl){
Author
Owner

Add test for this new function.

Add test for this new function.
Author
Owner

Test added in commit bee8d6d306

Test added in commit bee8d6d306
sigonasr2 marked this conversation as resolved
sigonasr2 reviewed 2025-05-13 16:43:06 -05:00
@ -81,2 +90,3 @@
const float GetConfigValue(const std::string_view keyName)const;
const float GetConfigValue(const std::string_view keyName)const;
const float operator[](const std::string&name)const;
const AbilityDescriptionModifiers GetModifiers()const;
Author
Owner

Add test for this new function.

Add test for this new function.
Author
Owner

Resolved in commit 67ca0d168d

Resolved in commit 67ca0d168d
sigonasr2 marked this conversation as resolved
sigonasr2 reviewed 2025-05-13 16:43:09 -05:00
@ -82,1 +90,4 @@
const float GetConfigValue(const std::string_view keyName)const;
const float operator[](const std::string&name)const;
const AbilityDescriptionModifiers GetModifiers()const;
static const std::vector<std::reference_wrapper<ItemEnchantInfo>>GetAllEnchantsAffectingAbility(const std::string_view ability);
Author
Owner

Add test for this new function.

Add test for this new function.
Author
Owner

Added in commit 2fea77c66c

Added in commit 2fea77c66c
sigonasr2 marked this conversation as resolved
sigonasr2 reviewed 2025-05-13 16:43:31 -05:00
@ -340,6 +340,7 @@ public:
void SetTestScreenAimingLocation(vf2d forcedAimingLoc);
const bool CoveredInInk()const;
const vf2d&GetPreviousPos()const; //The position the player was at on the last frame, can be used for comparison purposes to predict where the player may be next.
const std::unordered_set<std::string>&GetEnchants()const; //Get all enchants currently affeting the player.
Author
Owner

Typo here in the comment.

Typo here in the comment.
Author
Owner

Fixed in commit f962e90cad

Fixed in commit f962e90cad
sigonasr2 marked this conversation as resolved
sigonasr2 reviewed 2025-05-13 16:50:07 -05:00
@ -25,0 +25,4 @@
Silly Large Purple Wizard Cloak
Peace sign on finishing a stage (wink)
Kitty Headband
Author
Owner

Add zombie heart eyes idea.

Add zombie heart eyes idea.
Author
Owner

Fixed in commit f962e90cad

Fixed in commit f962e90cad
sigonasr2 marked this conversation as resolved
sigonasr2 added 2 commits 2025-05-15 00:14:11 -05:00
sigonasr2 added 1 commit 2025-05-15 00:38:31 -05:00
Add StringToClass and ClassToString unit tests. Release Build 12192.
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 6m49s
bee8d6d306
sigonasr2 added 1 commit 2025-05-15 02:17:30 -05:00
Add new test config files. Add in test to read enchant modifiers for function GetModifiers(). Release Build 12193.
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 6m41s
67ca0d168d
sigonasr2 added 1 commit 2025-05-15 08:58:13 -05:00
Add AllEnchantsAffectingAbility() unit tests.
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 6m53s
38d72e24a1
sigonasr2 added 1 commit 2025-05-15 10:57:54 -05:00
Fix tests for GetAllEnchantsAffectingAbility. Release Build 12194.
Some checks failed
Emscripten Build / Build_and_Deploy_Web_Build (push) Has been cancelled
2fea77c66c
sigonasr2 added 1 commit 2025-05-15 11:02:38 -05:00
Additional fixes. Finalized branch build. Ready for PR.
All checks were successful
Emscripten Build / Build_and_Deploy_Web_Build (push) Successful in 7m10s
f962e90cad
sigonasr2 changed title from WIP: DynamicItemDescriptions Review to DynamicItemDescriptions Review 2025-05-15 11:12:20 -05:00
sigonasr2 merged commit 25c196a563 into master 2025-05-15 11:12:36 -05:00
sigonasr2 deleted branch DynamicItemDescriptions 2025-05-15 11:12:36 -05:00
Sign in to join this conversation.
No description provided.