sigonasr2
/
jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Modified to use the new SafeArrayList for children and controls.

Browse Source 
This means it is possible for a control to modify its own
node hierarchy in a way that might have caused random skipping
at best and index out of bounds exceptions at worse.
Also, users can iterate over children and detach them at the
same time using standard for each constructs.
Performance is the same for me though I'd expected it to be
at least slightly faster given that most inner loops now use
direct array access.  My scenes must not exploit this much.


git-svn-id: https://jmonkeyengine.googlecode.com/svn/trunk@7857 75d07b2b-3a1a-0410-a2c5-0572b91ccdca
3.0
PSp..om 14 years ago
parent 11ab79a766
commit 349c9d9e4a
3 changed files with 54 additions and 50 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 5
      engine/src/core/com/jme3/scene/AssetLinkNode.java
  2. 74
      engine/src/core/com/jme3/scene/Node.java
  3. 25
      engine/src/core/com/jme3/scene/Spatial.java

5
engine/src/core/com/jme3/scene/AssetLinkNode.java
Unescape View File

@ -40,6 +40,7 @@ import com.jme3.export.JmeExporter;
import com.jme3.export.JmeImporter; import com.jme3.export.JmeImporter;
import com.jme3.export.OutputCapsule; import com.jme3.export.OutputCapsule;
import com.jme3.export.binary.BinaryImporter; import com.jme3.export.binary.BinaryImporter;
import com.jme3.util.SafeArrayList;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashMap; import java.util.HashMap;
@ -177,8 +178,8 @@ public class AssetLinkNode extends Node {
@Override @Override
public void write(JmeExporter e) throws IOException { public void write(JmeExporter e) throws IOException {
ArrayList<Spatial> childs = children; SafeArrayList<Spatial> childs = children;
children = new ArrayList<Spatial>(); children = new SafeArrayList<Spatial>(Spatial.class);
super.write(e); super.write(e);
OutputCapsule capsule = e.getCapsule(this); OutputCapsule capsule = e.getCapsule(this);
capsule.writeSavableArrayList(assetLoaderKeys, "assetLoaderKeyList", null); capsule.writeSavableArrayList(assetLoaderKeys, "assetLoaderKeyList", null);

74
engine/src/core/com/jme3/scene/Node.java
Unescape View File

@ -39,6 +39,7 @@ import com.jme3.export.JmeExporter;
import com.jme3.export.JmeImporter; import com.jme3.export.JmeImporter;
import com.jme3.export.Savable; import com.jme3.export.Savable;
import com.jme3.material.Material; import com.jme3.material.Material;
import com.jme3.util.SafeArrayList;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@ -65,7 +66,7 @@ public class Node extends Spatial implements Savable {
/** /**
* This node's children. * This node's children.
*/ */
protected ArrayList<Spatial> children = new ArrayList<Spatial>(1); protected SafeArrayList<Spatial> children = new SafeArrayList<Spatial>(Spatial.class);
/** /**
* Serialization only. Do not use. * Serialization only. Do not use.
@ -99,7 +100,7 @@ public class Node extends Spatial implements Savable {
@Override @Override
protected void setTransformRefresh(){ protected void setTransformRefresh(){
super.setTransformRefresh(); super.setTransformRefresh();
for (Spatial child : children){ for (Spatial child : children.getArray()){
if ((child.refreshFlags & RF_TRANSFORM) != 0) if ((child.refreshFlags & RF_TRANSFORM) != 0)
continue; continue;
@ -110,7 +111,7 @@ public class Node extends Spatial implements Savable {
@Override @Override
protected void setLightListRefresh(){ protected void setLightListRefresh(){
super.setLightListRefresh(); super.setLightListRefresh();
for (Spatial child : children){ for (Spatial child : children.getArray()){
if ((child.refreshFlags & RF_LIGHTLIST) != 0) if ((child.refreshFlags & RF_LIGHTLIST) != 0)
continue; continue;
@ -121,11 +122,11 @@ public class Node extends Spatial implements Savable {
@Override @Override
protected void updateWorldBound(){ protected void updateWorldBound(){
super.updateWorldBound(); super.updateWorldBound();
// for a node, the world bound is a combination of all it's children // for a node, the world bound is a combination of all it's children
// bounds // bounds
BoundingVolume resultBound = null; BoundingVolume resultBound = null;
for (int i = 0, cSize = children.size(); i < cSize; i++) { for (Spatial child : children.getArray()) {
Spatial child = children.get(i);
// child bound is assumed to be updated // child bound is assumed to be updated
assert (child.refreshFlags & RF_BOUND) == 0; assert (child.refreshFlags & RF_BOUND) == 0;
if (resultBound != null) { if (resultBound != null) {
@ -145,11 +146,11 @@ public class Node extends Spatial implements Savable {
public void updateLogicalState(float tpf){ public void updateLogicalState(float tpf){
super.updateLogicalState(tpf); super.updateLogicalState(tpf);
// FIXME: Iterating through the children list backwards if (children.isEmpty()) {
// to avoid IndexOutOfBoundsException. This is sometimes unreliable, return;
// a more robust solution is needed. }
for (int i = children.size()-1; i >= 0; i--){
Spatial child = children.get(i); for (Spatial child : children.getArray()) {
child.updateLogicalState(tpf); child.updateLogicalState(tpf);
} }
} }
@ -166,15 +167,16 @@ public class Node extends Spatial implements Savable {
updateWorldTransforms(); updateWorldTransforms();
} }
// the important part- make sure child geometric state is refreshed if (!children.isEmpty()) {
// first before updating own world bound. This saves // the important part- make sure child geometric state is refreshed
// a round-trip later on. // first before updating own world bound. This saves
// NOTE 9/19/09 // a round-trip later on.
// Although it does save a round trip, // NOTE 9/19/09
for (int i = 0, cSize = children.size(); i < cSize; i++) { // Although it does save a round trip,
Spatial child = children.get(i); for (Spatial child : children.getArray()) {
child.updateGeometricState(); child.updateGeometricState();
} }
}
if ((refreshFlags & RF_BOUND) != 0){ if ((refreshFlags & RF_BOUND) != 0){
updateWorldBound(); updateWorldBound();
@ -428,8 +430,7 @@ public class Node extends Spatial implements Savable {
if (name == null) if (name == null)
return null; return null;
for (int x = 0, cSize = getQuantity(); x < cSize; x++) { for (Spatial child : children.getArray()) {
Spatial child = children.get(x);
if (name.equals(child.getName())) { if (name.equals(child.getName())) {
return child; return child;
} else if(child instanceof Node) { } else if(child instanceof Node) {
@ -454,8 +455,7 @@ public class Node extends Spatial implements Savable {
if (children.contains(spat)) if (children.contains(spat))
return true; return true;
for (int i = 0, max = getQuantity(); i < max; i++) { for (Spatial child : children.getArray()) {
Spatial child = children.get(i);
if (child instanceof Node && ((Node) child).hasChild(spat)) if (child instanceof Node && ((Node) child).hasChild(spat))
return true; return true;
} }
@ -483,14 +483,14 @@ public class Node extends Spatial implements Savable {
@Override @Override
public void setLodLevel(int lod){ public void setLodLevel(int lod){
super.setLodLevel(lod); super.setLodLevel(lod);
for (int i = 0; i < children.size(); i++){ for (Spatial child : children.getArray()) {
children.get(i).setLodLevel(lod); child.setLodLevel(lod);
} }
} }
public int collideWith(Collidable other, CollisionResults results){ public int collideWith(Collidable other, CollisionResults results){
int total = 0; int total = 0;
for (Spatial child : children){ for (Spatial child : children.getArray()){
total += child.collideWith(other, results); total += child.collideWith(other, results);
} }
return total; return total;
@ -575,7 +575,7 @@ public class Node extends Spatial implements Savable {
@Override @Override
public Spatial deepClone(){ public Spatial deepClone(){
Node nodeClone = (Node) super.clone(); Node nodeClone = (Node) super.clone();
nodeClone.children = new ArrayList<Spatial>(); nodeClone.children = new SafeArrayList<Spatial>(Spatial.class);
for (Spatial child : children){ for (Spatial child : children){
Spatial childClone = child.deepClone(); Spatial childClone = child.deepClone();
childClone.parent = nodeClone; childClone.parent = nodeClone;
@ -587,7 +587,7 @@ public class Node extends Spatial implements Savable {
@Override @Override
public void write(JmeExporter e) throws IOException { public void write(JmeExporter e) throws IOException {
super.write(e); super.write(e);
e.getCapsule(this).writeSavableArrayList(children, "children", null); e.getCapsule(this).writeSavableArrayList(new ArrayList(children), "children", null);
} }
@Override @Override
@ -596,12 +596,12 @@ public class Node extends Spatial implements Savable {
// This prevents empty children list if controls query // This prevents empty children list if controls query
// it in Control.setSpatial(). // it in Control.setSpatial().
children = e.getCapsule(this).readSavableArrayList("children", null); children = new SafeArrayList( Spatial.class,
e.getCapsule(this).readSavableArrayList("children", null) );
// go through children and set parent to this node // go through children and set parent to this node
if (children != null) { if (children != null) {
for (int x = 0, cSize = children.size(); x < cSize; x++) { for (Spatial child : children.getArray()) {
Spatial child = children.get(x);
child.parent = this; child.parent = this;
} }
} }
@ -612,8 +612,8 @@ public class Node extends Spatial implements Savable {
@Override @Override
public void setModelBound(BoundingVolume modelBound) { public void setModelBound(BoundingVolume modelBound) {
if(children != null) { if(children != null) {
for(int i = 0, max = children.size(); i < max; i++) { for (Spatial child : children.getArray()) {
children.get(i).setModelBound(modelBound != null ? modelBound.clone(null) : null); child.setModelBound(modelBound != null ? modelBound.clone(null) : null);
} }
} }
} }
@ -621,16 +621,16 @@ public class Node extends Spatial implements Savable {
@Override @Override
public void updateModelBound() { public void updateModelBound() {
if(children != null) { if(children != null) {
for(int i = 0, max = children.size(); i < max; i++) { for (Spatial child : children.getArray()) {
children.get(i).updateModelBound(); child.updateModelBound();
} }
} }
} }
@Override @Override
public void depthFirstTraversal(SceneGraphVisitor visitor) { public void depthFirstTraversal(SceneGraphVisitor visitor) {
for(int i = 0, max = children.size(); i < max; i++) { for (Spatial child : children.getArray()) {
children.get(i).depthFirstTraversal(visitor); child.depthFirstTraversal(visitor);
} }
visitor.visit(this); visitor.visit(this);
} }

25
engine/src/core/com/jme3/scene/Spatial.java
Unescape View File

@ -53,6 +53,7 @@ import com.jme3.renderer.queue.RenderQueue;
import com.jme3.renderer.queue.RenderQueue.Bucket; import com.jme3.renderer.queue.RenderQueue.Bucket;
import com.jme3.renderer.queue.RenderQueue.ShadowMode; import com.jme3.renderer.queue.RenderQueue.ShadowMode;
import com.jme3.scene.control.Control; import com.jme3.scene.control.Control;
import com.jme3.util.SafeArrayList;
import com.jme3.util.TempVars; import com.jme3.util.TempVars;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
@ -131,7 +132,7 @@ public abstract class Spatial implements Savable, Cloneable, Collidable {
public transient float queueDistance = Float.NEGATIVE_INFINITY; public transient float queueDistance = Float.NEGATIVE_INFINITY;
protected Transform localTransform; protected Transform localTransform;
protected Transform worldTransform; protected Transform worldTransform;
protected ArrayList<Control> controls = new ArrayList<Control>(1); protected SafeArrayList<Control> controls = new SafeArrayList<Control>(Control.class);
protected HashMap<String, Savable> userData = null; protected HashMap<String, Savable> userData = null;
/** /**
* Spatial's parent, or null if it has none. * Spatial's parent, or null if it has none.
@ -512,8 +513,8 @@ public abstract class Spatial implements Savable, Cloneable, Collidable {
return; return;
} }
for (int i = 0; i < controls.size(); i++) { for (Control c : controls.getArray()) {
controls.get(i).update(tpf); c.update(tpf);
} }
} }
@ -532,8 +533,8 @@ public abstract class Spatial implements Savable, Cloneable, Collidable {
return; return;
} }
for (int i = 0; i < controls.size(); i++) { for (Control c : controls.getArray() ) {
controls.get(i).render(rm, vp); c.render(rm, vp);
} }
} }
@ -590,9 +591,9 @@ public abstract class Spatial implements Savable, Cloneable, Collidable {
* @see Spatial#addControl(com.jme3.scene.control.Control) * @see Spatial#addControl(com.jme3.scene.control.Control)
*/ */
public <T extends Control> T getControl(Class<T> controlType) { public <T extends Control> T getControl(Class<T> controlType) {
for (int i = 0; i < controls.size(); i++) { for (Control c : controls.getArray()) {
if (controlType.isAssignableFrom(controls.get(i).getClass())) { if (controlType.isAssignableFrom(c.getClass())) {
return (T) controls.get(i); return (T)c;
} }
} }
return null; return null;
@ -1114,7 +1115,7 @@ public abstract class Spatial implements Savable, Cloneable, Collidable {
if (clone instanceof Node) { if (clone instanceof Node) {
Node node = (Node) this; Node node = (Node) this;
Node nodeClone = (Node) clone; Node nodeClone = (Node) clone;
nodeClone.children = new ArrayList<Spatial>(); nodeClone.children = new SafeArrayList<Spatial>(Spatial.class);
for (Spatial child : node.children) { for (Spatial child : node.children) {
Spatial childClone = child.clone(cloneMaterial); Spatial childClone = child.clone(cloneMaterial);
childClone.parent = nodeClone; childClone.parent = nodeClone;
@ -1127,7 +1128,7 @@ public abstract class Spatial implements Savable, Cloneable, Collidable {
clone.setTransformRefresh(); clone.setTransformRefresh();
clone.setLightListRefresh(); clone.setLightListRefresh();
clone.controls = new ArrayList<Control>(); clone.controls = new SafeArrayList<Control>(Control.class);
for (int i = 0; i < controls.size(); i++) { for (int i = 0; i < controls.size(); i++) {
clone.controls.add(controls.get(i).cloneForSpatial(clone)); clone.controls.add(controls.get(i).cloneForSpatial(clone));
} }
@ -1240,7 +1241,9 @@ public abstract class Spatial implements Savable, Cloneable, Collidable {
capsule.write(shadowMode, "shadow_mode", ShadowMode.Inherit); capsule.write(shadowMode, "shadow_mode", ShadowMode.Inherit);
capsule.write(localTransform, "transform", Transform.IDENTITY); capsule.write(localTransform, "transform", Transform.IDENTITY);
capsule.write(localLights, "lights", null); capsule.write(localLights, "lights", null);
capsule.writeSavableArrayList(controls, "controlsList", null);
// Shallow clone the controls array to convert its type.
capsule.writeSavableArrayList( new ArrayList(controls), "controlsList", null);
capsule.writeStringSavableMap(userData, "user_data", null); capsule.writeStringSavableMap(userData, "user_data", null);
} }

Write Preview
Loading…
Cancel
Save