sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* If the render buffer storage format is 0 (not supported), throw exception instead of passing invalid enum to a GL call

Browse Source 
git-svn-id: https://jmonkeyengine.googlecode.com/svn/trunk@10523 75d07b2b-3a1a-0410-a2c5-0572b91ccdca
This commit is contained in:
sha..RD 2013-04-07 19:05:34 +00:00
parent bcf3b7e7b6
commit 30c7347cdf
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/android/com/jme3/renderer/android/OGLESShaderRenderer.java
View File

@ -39,6 +39,7 @@ import com.jme3.light.LightList;
import com.jme3.material.RenderState; import com.jme3.material.RenderState;
import com.jme3.math.*; import com.jme3.math.*;
import com.jme3.renderer.*; import com.jme3.renderer.*;
import com.jme3.renderer.android.TextureUtil.AndroidGLImageFormat;
import com.jme3.scene.Mesh; import com.jme3.scene.Mesh;
import com.jme3.scene.Mesh.Mode; import com.jme3.scene.Mesh.Mode;
import com.jme3.scene.VertexBuffer; import com.jme3.scene.VertexBuffer;
@ -1174,7 +1175,10 @@ public class OGLESShaderRenderer implements Renderer {
+ ":" + fb.getHeight() + " is not supported."); + ":" + fb.getHeight() + " is not supported.");
} }
int glRenderBufferStorageFormat = TextureUtil.getImageFormat(rb.getFormat()).renderBufferStorageFormat; AndroidGLImageFormat imageFormat = TextureUtil.getImageFormat(rb.getFormat());
if (imageFormat.renderBufferStorageFormat == 0) {
throw new RendererException("The format '" + rb.getFormat() + "' cannot be used for renderbuffers.")
}
// if (fb.getSamples() > 1 && GLContext.getCapabilities().GL_EXT_framebuffer_multisample) { // if (fb.getSamples() > 1 && GLContext.getCapabilities().GL_EXT_framebuffer_multisample) {
if (fb.getSamples() > 1) { if (fb.getSamples() > 1) {
@ -1191,7 +1195,7 @@ public class OGLESShaderRenderer implements Renderer {
// fb.getHeight()); // fb.getHeight());
} else { } else {
GLES20.glRenderbufferStorage(GLES20.GL_RENDERBUFFER, GLES20.glRenderbufferStorage(GLES20.GL_RENDERBUFFER,
glRenderBufferStorageFormat, imageFormat.renderBufferStorageFormat,
fb.getWidth(), fb.getWidth(),
fb.getHeight()); fb.getHeight());
} }