sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Modified the clone function lookup to support inheritence.

Browse Source 
It's just too useful for things like Mesh which has a dozen
or more subclasses... more useful than the limitations.
This commit is contained in:
Paul Speed 2016-03-27 05:38:43 -04:00
parent 2028f3b3f8
commit f7c16e878e
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
jme3-core/src/main/java/com/jme3/util/clone/Cloner.java
View File

@ -277,10 +277,12 @@ public class Cloner {
} }
/** /**
* Sets a custom CloneFunction for the exact Java type. Note: no inheritence * Sets a custom CloneFunction for implementations of the specified Java type. Some
* checks are performed so a function must be registered for each specific type * inheritance checks are made but no disambiguation is performed.
* that it handles. By default ListCloneFunction is registered for * <p>Note: in the general case, it is better to register against specific classes and
* ArrayList, LinkedList, CopyOnWriteArrayList, Vector, Stack, and JME's SafeArrayList. * not super-classes or super-interfaces unless you know specifically that they are cloneable.</p>
* <p>By default ListCloneFunction is registered for ArrayList, LinkedList, CopyOnWriteArrayList,
* Vector, Stack, and JME's SafeArrayList.</p>
*/ */
public <T> void setCloneFunction( Class<T> type, CloneFunction<T> function ) { public <T> void setCloneFunction( Class<T> type, CloneFunction<T> function ) {
if( function == null ) { if( function == null ) {
@ -296,7 +298,21 @@ public class Cloner {
*/ */
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
public <T> CloneFunction<T> getCloneFunction( Class<T> type ) { public <T> CloneFunction<T> getCloneFunction( Class<T> type ) {
return (CloneFunction<T>)functions.get(type); CloneFunction<T> result = (CloneFunction<T>)functions.get(type);
if( result == null ) {
// Do a more exhaustive search
for( Map.Entry<Class, CloneFunction> e : functions.entrySet() ) {
if( e.getKey().isAssignableFrom(type) ) {
result = e.getValue();
break;
}
}
if( result != null ) {
// Cache it for later
functions.put(type, result);
}
}
return result;
} }
/** /**