sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Another fix for BitmapText cloning where the regular clone() was

Browse Source 
completely bypassing the JME cloner framework... and making a bad
clone.
This commit is contained in:
Paul Speed 2016-12-04 15:31:30 -05:00 committed by Paul Speed
parent 440096441d
commit dbb1f14471
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
jme3-core/src/main/java/com/jme3/font/BitmapText.java
View File

@ -76,13 +76,7 @@ public class BitmapText extends Node {
@Override @Override
public BitmapText clone() { public BitmapText clone() {
BitmapText clone = (BitmapText) super.clone(); return (BitmapText)super.clone(false);
for (int i = 0; i < textPages.length; i++) {
clone.textPages[i] = textPages[i].clone();
}
clone.block = block.clone();
clone.needRefresh = true;
return clone;
} }
/** /**
@ -105,7 +99,7 @@ public class BitmapText extends Node {
// Change in behavior: The 'letters' field was not cloned or recreated // Change in behavior: The 'letters' field was not cloned or recreated
// before. I'm not sure how this worked and suspect BitmapText was just // before. I'm not sure how this worked and suspect BitmapText was just
// not cloneable if you planned to change the text later. -pspeed // not cloneable if you planned to change the text later. -pspeed
this.letters = new Letters(font, this.block, letters.getQuad().isRightToLeft()); this.letters = new Letters(font, block, letters.getQuad().isRightToLeft());
// Just noticed BitmapText is not even writable/readable really... // Just noticed BitmapText is not even writable/readable really...
// so I guess cloning doesn't come up that often. // so I guess cloning doesn't come up that often.