sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed MikktSpaceTangentGenerator that was not replacing existing Tangent buffers on the mesh. That could cause crashes when the old tangent buffer did not have the same amount of components

Browse Source
This commit is contained in:
Nehon 2016-12-30 10:08:21 +01:00
parent 8d818a21bc
commit bf2369a50a
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
jme3-core/src/main/java/com/jme3/util/mikktspace/MikkTSpaceImpl.java
View File

@ -21,15 +21,12 @@ public class MikkTSpaceImpl implements MikkTSpaceContext {
public MikkTSpaceImpl(Mesh mesh) { public MikkTSpaceImpl(Mesh mesh) {
this.mesh = mesh; this.mesh = mesh;
VertexBuffer tangentBuffer = mesh.getBuffer(VertexBuffer.Type.Tangent); //replacing any existing tangent buffer, if you came here you want them new.
if(tangentBuffer == null){ mesh.clearBuffer(VertexBuffer.Type.Tangent);
FloatBuffer fb = BufferUtils.createFloatBuffer(mesh.getVertexCount() * 4); FloatBuffer fb = BufferUtils.createFloatBuffer(mesh.getVertexCount() * 4);
mesh.setBuffer(VertexBuffer.Type.Tangent, 4, fb); mesh.setBuffer(VertexBuffer.Type.Tangent, 4, fb);
} }
//TODO ensure the Tangent buffer exists, else create one.
}
@Override @Override
public int getNumFaces() { public int getNumFaces() {
return mesh.getTriangleCount(); return mesh.getTriangleCount();