sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Reduce "Integer" class churn in rendering statistics

Browse Source 
* Use IntMap instead of HashMap<Integer>
 * Cache last set shader to save hashmap lookup on every set uniform
This commit is contained in:
shadowislord 2014-11-08 18:04:03 -05:00
parent ff55522f78
commit bbd6c613f0
1 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
jme3-core/src/main/java/com/jme3/renderer/Statistics.java
View File

@ -35,6 +35,7 @@ import com.jme3.scene.Mesh;
import com.jme3.shader.Shader; import com.jme3.shader.Shader;
import com.jme3.texture.FrameBuffer; import com.jme3.texture.FrameBuffer;
import com.jme3.texture.Image; import com.jme3.texture.Image;
import com.jme3.util.IntMap;
import java.util.HashSet; import java.util.HashSet;
/** /**
@ -60,9 +61,11 @@ public class Statistics {
protected int memoryFrameBuffers; protected int memoryFrameBuffers;
protected int memoryTextures; protected int memoryTextures;
protected HashSet<Integer> shadersUsed = new HashSet<Integer>(); protected IntMap<Void> shadersUsed = new IntMap<Void>();
protected HashSet<Integer> texturesUsed = new HashSet<Integer>(); protected IntMap<Void> texturesUsed = new IntMap<Void>();
protected HashSet<Integer> fbosUsed = new HashSet<Integer>(); protected IntMap<Void> fbosUsed = new IntMap<Void>();
protected int lastShader = -1;
/** /**
* Returns a list of labels corresponding to each statistic. * Returns a list of labels corresponding to each statistic.
@ -149,8 +152,14 @@ public class Statistics {
if( !enabled ) if( !enabled )
return; return;
if (!shadersUsed.contains(shader.getId())) // Reduces unneccessary hashmap lookups if
shadersUsed.add(shader.getId()); // we already considered this shader.
if (lastShader != shader.getId()) {
lastShader = shader.getId();
if (!shadersUsed.containsKey(shader.getId())) {
shadersUsed.put(shader.getId(), null);
}
}
if (wasSwitched) if (wasSwitched)
numShaderSwitches++; numShaderSwitches++;
@ -177,8 +186,8 @@ public class Statistics {
if( !enabled ) if( !enabled )
return; return;
if (!texturesUsed.contains(image.getId())) if (!texturesUsed.containsKey(image.getId()))
texturesUsed.add(image.getId()); texturesUsed.put(image.getId(), null);
if (wasSwitched) if (wasSwitched)
numTextureBinds ++; numTextureBinds ++;
@ -197,8 +206,8 @@ public class Statistics {
if (fb != null){ if (fb != null){
assert fb.getId() >= 1; assert fb.getId() >= 1;
if (!fbosUsed.contains(fb.getId())) if (!fbosUsed.containsKey(fb.getId()))
fbosUsed.add(fb.getId()); fbosUsed.put(fb.getId(), null);
} }
if (wasSwitched) if (wasSwitched)
@ -220,6 +229,8 @@ public class Statistics {
numTextureBinds = 0; numTextureBinds = 0;
numFboSwitches = 0; numFboSwitches = 0;
numUniformsSet = 0; numUniformsSet = 0;
lastShader = -1;
} }
/** /**