From abdd739437b956008095abc45e03b9dc6783de72 Mon Sep 17 00:00:00 2001 From: NemesisMate Date: Fri, 18 Dec 2015 12:11:54 +0000 Subject: [PATCH] Fixed BetterCharacterControl "flickering" when not moving. Sometimes, when the BetterCharacterControl is not moving, it flickers due it physics being always active. The reason for it being always active is that on the prePhysicsTick method it always set the rigidBody's linear velocity (and the method PhysicsRigidBody.setLinearVelocity(Vector3f) reactivates the physics each time is called). The fix consist on just comparing if the current velocity and the setting one aren't the same and, thus, not setting it (using ZERO_TOLERANCE instead 0 to best results). --- .../java/com/jme3/bullet/control/BetterCharacterControl.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/jme3-bullet/src/common/java/com/jme3/bullet/control/BetterCharacterControl.java b/jme3-bullet/src/common/java/com/jme3/bullet/control/BetterCharacterControl.java index 065a645eb..c91c1be1d 100644 --- a/jme3-bullet/src/common/java/com/jme3/bullet/control/BetterCharacterControl.java +++ b/jme3-bullet/src/common/java/com/jme3/bullet/control/BetterCharacterControl.java @@ -171,6 +171,8 @@ public class BetterCharacterControl extends AbstractPhysicsControl implements Ph } TempVars vars = TempVars.get(); + Vector3f currentVelocity = vars.vect2.set(velocity); + // dampen existing x/z forces float existingLeftVelocity = velocity.dot(localLeft); float existingForwardVelocity = velocity.dot(localForward); @@ -194,7 +196,7 @@ public class BetterCharacterControl extends AbstractPhysicsControl implements Ph //add resulting vector to existing velocity velocity.addLocal(localWalkDirection); } - rigidBody.setLinearVelocity(velocity); + if(currentVelocity.distance(velocity) > FastMath.ZERO_TOLERANCE) rigidBody.setLinearVelocity(velocity); if (jump) { //TODO: precalculate jump force Vector3f rotatedJumpForce = vars.vect1;