sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix small things ()

Browse Source 
* JmeVersion: Don't throw a NullPointerException when version.properties can't be found.

* ImplHandler: Reduce Code-Duplication by using a multi-catch statement
This commit is contained in:
MeFisto94 2020-02-12 19:48:46 +01:00 committed by GitHub
parent f268d00222
commit ab96460853
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 10 deletions
jme3-core/src/main/java/com/jme3
asset
ImplHandler.java
system
JmeVersion.java

11
jme3-core/src/main/java/com/jme3/asset/ImplHandler.java

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2009-2012 jMonkeyEngine * Copyright (c) 2009-2020 jMonkeyEngine
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -120,16 +120,11 @@ final class ImplHandler {
((AssetLocator)obj).setRootPath(path); ((AssetLocator)obj).setRootPath(path);
} }
return obj; return obj;
} catch (InstantiationException ex) { } catch (InstantiationException | IllegalAccessException ex) {
logger.log(Level.SEVERE,"Cannot create locator of type {0}, does" logger.log(Level.SEVERE,"Cannot create locator of type {0}, does"
+ " the class have an empty and publically accessible"+ + " the class have an empty and publicly accessible"+
" constructor?", type.getName()); " constructor?", type.getName());
logger.throwing(type.getName(), "<init>", ex); logger.throwing(type.getName(), "<init>", ex);
} catch (IllegalAccessException ex) {
logger.log(Level.SEVERE,"Cannot create locator of type {0}, "
+ "does the class have an empty and publically "
+ "accessible constructor?", type.getName());
logger.throwing(type.getName(), "<init>", ex);
} }
return null; return null;
} }

4
jme3-core/src/main/java/com/jme3/system/JmeVersion.java

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2009-2015 jMonkeyEngine * Copyright (c) 2009-2020 jMonkeyEngine
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -49,7 +49,7 @@ public class JmeVersion {
static { static {
try { try {
props.load(JmeVersion.class.getResourceAsStream("version.properties")); props.load(JmeVersion.class.getResourceAsStream("version.properties"));
} catch (IOException ex) { } catch (IOException | NullPointerException ex) {
logger.log(Level.WARNING, "Unable to read version info!", ex); logger.log(Level.WARNING, "Unable to read version info!", ex);
} }
} }