sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added a (hacky) fix for a Java Swing/AWT + GLFW interaction issue… (#968)

Browse Source 
* Added a (hacky) fix for a Java Swing/AWT + GLFW interaction issue… 

… on Linux.

* Added a proper comment

* Added an extra call to System.gc() as recommendation from lwjgl’s @Spasi

"Run System.gc(), at least two times. Not sure how AWT handles native
resources, maybe there’s a finalizable/PhantomRef-ed resource that is not
released immediately, but a subsequent GC triggers a (too late) free. "
This commit is contained in:
Ali-RS 2018-12-14 11:49:25 +03:30 committed by empirephoenix
parent d8acd30a27
commit a47b4a46ba
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
jme3-desktop/src/main/java/com/jme3/app/SettingsDialog.java
View File

@ -442,6 +442,12 @@ public final class SettingsDialog extends JFrame {
if (verifyAndSaveCurrentSelection()) { if (verifyAndSaveCurrentSelection()) {
setUserSelection(APPROVE_SELECTION); setUserSelection(APPROVE_SELECTION);
dispose(); dispose();
// System.gc() should be called to prevent "X Error of failed request: RenderBadPicture (invalid Picture parameter)"
// on Linux when using AWT/Swing + GLFW.
// For more info see: https://github.com/LWJGL/lwjgl3/issues/149, https://hub.jmonkeyengine.org/t/experimenting-lwjgl3/37275
System.gc();
System.gc();
} }
} }
}); });