From 98f6d326e1d062aa4e1103e4729c02f0c0f16cc1 Mon Sep 17 00:00:00 2001 From: Stephen Gold Date: Wed, 4 Dec 2019 12:01:40 -0800 Subject: [PATCH] re-publicize InstancedGeometry no-arg constructor, correct erroneous javadoc (#1230) * re-publicize 3 no-arg constructors, correct/remove erroneous javadoc * re-protect 2 no-arg constructors, restore javadoc --- jme3-core/src/main/java/com/jme3/scene/Geometry.java | 3 ++- jme3-core/src/main/java/com/jme3/scene/Node.java | 7 +++---- .../java/com/jme3/scene/instancing/InstancedGeometry.java | 5 +---- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/jme3-core/src/main/java/com/jme3/scene/Geometry.java b/jme3-core/src/main/java/com/jme3/scene/Geometry.java index adc1d51a5..424b44504 100644 --- a/jme3-core/src/main/java/com/jme3/scene/Geometry.java +++ b/jme3-core/src/main/java/com/jme3/scene/Geometry.java @@ -98,7 +98,8 @@ public class Geometry extends Spatial { private int nbSimultaneousGPUMorph = -1; /** - * Serialization only. Do not use. + * Instantiate a Geometry with no name, no mesh, and no + * material. The mesh and material must be set prior to rendering. */ public Geometry() { this(null); diff --git a/jme3-core/src/main/java/com/jme3/scene/Node.java b/jme3-core/src/main/java/com/jme3/scene/Node.java index d16246d2d..6fa788392 100644 --- a/jme3-core/src/main/java/com/jme3/scene/Node.java +++ b/jme3-core/src/main/java/com/jme3/scene/Node.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009-2018 jMonkeyEngine + * Copyright (c) 2009-2019 jMonkeyEngine * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -83,7 +83,7 @@ public class Node extends Spatial { private boolean updateListValid = false; /** - * Serialization only. Do not use. + * Instantiate a Node with no name, no parent, and no children. */ public Node() { this(null); @@ -93,8 +93,7 @@ public class Node extends Spatial { * Constructor instantiates a new Node with a default empty * list for containing children. * - * @param name the name of the scene element. This is required for - * identification and comparison purposes. + * @param name the name of the scene element */ public Node(String name) { super(name); diff --git a/jme3-core/src/main/java/com/jme3/scene/instancing/InstancedGeometry.java b/jme3-core/src/main/java/com/jme3/scene/instancing/InstancedGeometry.java index 6749005be..b622ab6e3 100644 --- a/jme3-core/src/main/java/com/jme3/scene/instancing/InstancedGeometry.java +++ b/jme3-core/src/main/java/com/jme3/scene/instancing/InstancedGeometry.java @@ -64,10 +64,7 @@ public class InstancedGeometry extends Geometry { private int firstUnusedIndex = 0; - /** - * Serialization only. Do not use. - */ - protected InstancedGeometry() { + public InstancedGeometry() { super(); setIgnoreTransform(true); setBatchHint(BatchHint.Never);