sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

avoid unchecked casts due by premature casting of Class objects

Browse Source
This commit is contained in:
Stephen Gold 2020-04-15 16:55:29 -07:00
parent 297443ada4
commit 88c9371a4d
7 changed files with 19 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
jme3-android/src/main/java/com/jme3/app/AndroidHarness.java
View File

@ -239,9 +239,8 @@ public class AndroidHarness extends Activity implements TouchListener, DialogInt
// Create application instance // Create application instance
try { try {
if (app == null) { if (app == null) {
@SuppressWarnings("unchecked") Class clazz = Class.forName(appClass);
Class<? extends LegacyApplication> clazz = (Class<? extends LegacyApplication>) Class.forName(appClass); app = (LegacyApplication)clazz.newInstance();
app = clazz.newInstance();
} }
app.setSettings(settings); app.setSettings(settings);

5
jme3-android/src/main/java/com/jme3/app/AndroidHarnessFragment.java
View File

@ -257,9 +257,8 @@ public class AndroidHarnessFragment extends Fragment implements
// Create application instance // Create application instance
try { try {
if (app == null) { if (app == null) {
@SuppressWarnings("unchecked") Class clazz = Class.forName(appClass);
Class<? extends LegacyApplication> clazz = (Class<? extends LegacyApplication>) Class.forName(appClass); app = (LegacyApplication)clazz.newInstance();
app = clazz.newInstance();
} }
app.setSettings(settings); app.setSettings(settings);

4
jme3-desktop/src/main/java/com/jme3/app/AppletHarness.java
View File

@ -103,8 +103,8 @@ public class AppletHarness extends Applet {
JmeSystem.setLowPermissions(true); JmeSystem.setLowPermissions(true);
try{ try{
Class<? extends LegacyApplication> clazz = (Class<? extends LegacyApplication>) Class.forName(appClass); Class clazz = Class.forName(appClass);
app = clazz.newInstance(); app = (LegacyApplication) clazz.newInstance();
}catch (ClassNotFoundException ex){ }catch (ClassNotFoundException ex){
ex.printStackTrace(); ex.printStackTrace();
}catch (InstantiationException ex){ }catch (InstantiationException ex){

15
jme3-desktop/src/main/java/com/jme3/system/JmeDesktopSystem.java
View File

@ -193,22 +193,22 @@ public class JmeDesktopSystem extends JmeSystemDelegate {
private JmeContext newContextLwjgl(AppSettings settings, JmeContext.Type type) { private JmeContext newContextLwjgl(AppSettings settings, JmeContext.Type type) {
try { try {
Class<? extends JmeContext> ctxClazz = null; Class ctxClazz = null;
switch (type) { switch (type) {
case Canvas: case Canvas:
ctxClazz = (Class<? extends JmeContext>) Class.forName("com.jme3.system.lwjgl.LwjglCanvas"); ctxClazz = Class.forName("com.jme3.system.lwjgl.LwjglCanvas");
break; break;
case Display: case Display:
ctxClazz = (Class<? extends JmeContext>) Class.forName("com.jme3.system.lwjgl.LwjglDisplay"); ctxClazz = Class.forName("com.jme3.system.lwjgl.LwjglDisplay");
break; break;
case OffscreenSurface: case OffscreenSurface:
ctxClazz = (Class<? extends JmeContext>) Class.forName("com.jme3.system.lwjgl.LwjglOffscreenBuffer"); ctxClazz = Class.forName("com.jme3.system.lwjgl.LwjglOffscreenBuffer");
break; break;
default: default:
throw new IllegalArgumentException("Unsupported context type " + type); throw new IllegalArgumentException("Unsupported context type " + type);
} }
return ctxClazz.newInstance(); return (JmeContext) ctxClazz.newInstance();
} catch (InstantiationException ex) { } catch (InstantiationException ex) {
logger.log(Level.SEVERE, "Failed to create context", ex); logger.log(Level.SEVERE, "Failed to create context", ex);
} catch (IllegalAccessException ex) { } catch (IllegalAccessException ex) {
@ -225,9 +225,8 @@ public class JmeDesktopSystem extends JmeSystemDelegate {
try { try {
String className = settings.getRenderer().substring("CUSTOM".length()); String className = settings.getRenderer().substring("CUSTOM".length());
Class<? extends JmeContext> ctxClazz = null; Class ctxClazz = Class.forName(className);
ctxClazz = (Class<? extends JmeContext>) Class.forName(className); return (JmeContext) ctxClazz.newInstance();
return ctxClazz.newInstance();
} catch (InstantiationException ex) { } catch (InstantiationException ex) {
logger.log(Level.SEVERE, "Failed to create context", ex); logger.log(Level.SEVERE, "Failed to create context", ex);
} catch (IllegalAccessException ex) { } catch (IllegalAccessException ex) {

4
jme3-examples/src/main/java/jme3test/awt/AppHarness.java
View File

@ -79,8 +79,8 @@ public class AppHarness extends Applet {
JmeSystem.setLowPermissions(true); JmeSystem.setLowPermissions(true);
try{ try{
Class<? extends LegacyApplication> clazz = (Class<? extends LegacyApplication>) Class.forName(appClass); Class clazz = Class.forName(appClass);
app = clazz.newInstance(); app = (LegacyApplication) clazz.newInstance();
}catch (ClassNotFoundException ex){ }catch (ClassNotFoundException ex){
ex.printStackTrace(); ex.printStackTrace();
}catch (InstantiationException ex){ }catch (InstantiationException ex){

4
jme3-examples/src/main/java/jme3test/awt/TestApplet.java
View File

@ -62,8 +62,8 @@ public class TestApplet extends Applet {
JmeSystem.setLowPermissions(true); JmeSystem.setLowPermissions(true);
try{ try{
Class<? extends LegacyApplication> clazz = (Class<? extends LegacyApplication>) Class.forName(appClass); Class clazz = Class.forName(appClass);
app = clazz.newInstance(); app = (LegacyApplication) clazz.newInstance();
}catch (ClassNotFoundException ex){ }catch (ClassNotFoundException ex){
ex.printStackTrace(); ex.printStackTrace();
}catch (InstantiationException ex){ }catch (InstantiationException ex){

4
jme3-examples/src/main/java/jme3test/awt/TestCanvas.java
View File

@ -209,8 +209,8 @@ public class TestCanvas {
settings.setHeight(480); settings.setHeight(480);
try{ try{
Class<? extends LegacyApplication> clazz = (Class<? extends LegacyApplication>) Class.forName(appClass); Class clazz = Class.forName(appClass);
app = clazz.newInstance(); app = (LegacyApplication)clazz.newInstance();
}catch (ClassNotFoundException ex){ }catch (ClassNotFoundException ex){
ex.printStackTrace(); ex.printStackTrace();
}catch (InstantiationException ex){ }catch (InstantiationException ex){