sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed IllegalArgumentException when removing a LodControl from a spatial

Browse Source 
LodControl throws an exception when the spatial being added to isn't a geometry, however, when the controls is removed it calls setSpatial with a null value triggering the exception throw. Now checking for this null value case.
This commit is contained in:
NemesisMate 2017-05-24 13:51:28 +01:00 committed by GitHub
parent 080a89e14b
commit 88125da16d
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
jme3-core/src/main/java/com/jme3/scene/control/LodControl.java
View File

@ -121,17 +121,23 @@ public class LodControl extends AbstractControl implements Cloneable, JmeCloneab
@Override @Override
public void setSpatial(Spatial spatial) { public void setSpatial(Spatial spatial) {
if (!(spatial instanceof Geometry)) { if (spatial != null && !(spatial instanceof Geometry)) {
throw new IllegalArgumentException("LodControl can only be attached to Geometry!"); throw new IllegalArgumentException("LodControl can only be attached to Geometry!");
} }
super.setSpatial(spatial); super.setSpatial(spatial);
Geometry geom = (Geometry) spatial;
Mesh mesh = geom.getMesh(); if(spatial != null) {
numLevels = mesh.getNumLodLevels(); Geometry geom = (Geometry) spatial;
numTris = new int[numLevels]; Mesh mesh = geom.getMesh();
for (int i = numLevels - 1; i >= 0; i--) { numLevels = mesh.getNumLodLevels();
numTris[i] = mesh.getTriangleCount(i); numTris = new int[numLevels];
for (int i = numLevels - 1; i >= 0; i--) {
numTris[i] = mesh.getTriangleCount(i);
}
} else {
numLevels = 0;
numTris = null;
} }
} }