sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Commented out the onFrameChange() in update() because

Browse Source 
its redundant.
Modified setGuiBounding to call the new setCenter(x,y,z)
method instead of allocating a Vector3f each time. (This
method is called any time someone sneezes.)
Fixed a missing line feed in a javadoc comment.
This commit is contained in:
pspeed42 2014-08-12 02:50:08 -04:00
parent efd6f0bf66
commit 5d6d2b9bd7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jme3-core/src/main/java/com/jme3/renderer/Camera.java
View File

@ -369,7 +369,8 @@ public class Camera implements Savable, Cloneable {
/** /**
* Sets a clipPlane for this camera. * Sets a clipPlane for this camera.
* The clipPlane is used to recompute the * The clipPlane is used to recompute the
* projectionMatrix using the plane as the near plane * This technique is known as the oblique near-plane clipping method introduced by Eric Lengyel * projectionMatrix using the plane as the near plane
* This technique is known as the oblique near-plane clipping method introduced by Eric Lengyel
* more info here * more info here
* <ul> * <ul>
* <li><a href="http://www.terathon.com/code/oblique.html">http://www.terathon.com/code/oblique.html</a> * <li><a href="http://www.terathon.com/code/oblique.html">http://www.terathon.com/code/oblique.html</a>
@ -868,7 +869,8 @@ public class Camera implements Savable, Cloneable {
public void update() { public void update() {
onFrustumChange(); onFrustumChange();
onViewPortChange(); onViewPortChange();
onFrameChange(); //...this is always called by onFrustumChange()
//onFrameChange();
} }
/** /**
@ -1154,7 +1156,7 @@ public class Camera implements Savable, Cloneable {
float ey = height * viewPortTop; float ey = height * viewPortTop;
float xExtent = Math.max(0f, (ex - sx) / 2f); float xExtent = Math.max(0f, (ex - sx) / 2f);
float yExtent = Math.max(0f, (ey - sy) / 2f); float yExtent = Math.max(0f, (ey - sy) / 2f);
guiBounding.setCenter(new Vector3f(sx + xExtent, sy + yExtent, 0)); guiBounding.setCenter(sx + xExtent, sy + yExtent, 0);
guiBounding.setXExtent(xExtent); guiBounding.setXExtent(xExtent);
guiBounding.setYExtent(yExtent); guiBounding.setYExtent(yExtent);
guiBounding.setZExtent(Float.MAX_VALUE); guiBounding.setZExtent(Float.MAX_VALUE);