From 3f1c696e2674f132fe989ec171c5c041d56380e1 Mon Sep 17 00:00:00 2001 From: Paul Speed Date: Sat, 26 Mar 2016 03:55:58 -0400 Subject: [PATCH] Adding a comment about the strange shared fields in BitmapTextPage that I'm not going to touch with a ten foot pole. --- jme3-core/src/main/java/com/jme3/font/BitmapTextPage.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/jme3-core/src/main/java/com/jme3/font/BitmapTextPage.java b/jme3-core/src/main/java/com/jme3/font/BitmapTextPage.java index 58dc87550..82d27aa65 100644 --- a/jme3-core/src/main/java/com/jme3/font/BitmapTextPage.java +++ b/jme3-core/src/main/java/com/jme3/font/BitmapTextPage.java @@ -123,6 +123,13 @@ class BitmapTextPage extends Geometry { return clone; } + // Here is where one might add JmeCloneable related stuff except + // the old clone() method doesn't actually bother to clone anything. + // The arrays and the pageQuads are shared across all BitmapTextPage + // clones and it doesn't seem to bother anything. That means the + // fields could probably just as well be static... but this code is + // all very fragile. I'm not tipping that particular boat today. -pspeed + void assemble(Letters quads) { pageQuads.clear(); quads.rewind();