Avoid allocation of a temporary float[] array

and avoid allocation of a needless Vector3f array.

jme3-core/src/main/java/com/jme3/bounding/BoundingBox.java

@@ -720,42 +720,45 @@ public class BoundingBox extends BoundingVolume {
      */
     private int collideWithRay(Ray ray, CollisionResults results) {
         TempVars vars = TempVars.get();
-
+        try {    
-        Vector3f diff = vars.vect1.set(ray.origin).subtractLocal(center);
+            Vector3f diff = vars.vect1.set(ray.origin).subtractLocal(center);
-        Vector3f direction = vars.vect2.set(ray.direction);
+            Vector3f direction = vars.vect2.set(ray.direction);
-
+
-        float[] t = {0f, Float.POSITIVE_INFINITY};
+            //float[] t = {0f, Float.POSITIVE_INFINITY};
-
+            float[] t = vars.fWdU; // use one of the tempvars arrays
-        float saveT0 = t[0], saveT1 = t[1];
+            t[0] = 0;
-        boolean notEntirelyClipped = clip(+direction.x, -diff.x - xExtent, t)
+            t[1] = Float.POSITIVE_INFINITY;  
-                && clip(-direction.x, +diff.x - xExtent, t)
+
-                && clip(+direction.y, -diff.y - yExtent, t)
+            float saveT0 = t[0], saveT1 = t[1];
-                && clip(-direction.y, +diff.y - yExtent, t)
+            boolean notEntirelyClipped = clip(+direction.x, -diff.x - xExtent, t)
-                && clip(+direction.z, -diff.z - zExtent, t)
+                    && clip(-direction.x, +diff.x - xExtent, t)
-                && clip(-direction.z, +diff.z - zExtent, t);
+                    && clip(+direction.y, -diff.y - yExtent, t)
-        vars.release();
+                    && clip(-direction.y, +diff.y - yExtent, t)
-
+                    && clip(+direction.z, -diff.z - zExtent, t)
-        if (notEntirelyClipped && (t[0] != saveT0 || t[1] != saveT1)) {
+                    && clip(-direction.z, +diff.z - zExtent, t);
-            if (t[1] > t[0]) {
+
-                float[] distances = t;
+            if (notEntirelyClipped && (t[0] != saveT0 || t[1] != saveT1)) {
-                Vector3f[] points = new Vector3f[]{
+                if (t[1] > t[0]) {
-                    new Vector3f(ray.direction).multLocal(distances[0]).addLocal(ray.origin),
+                    float[] distances = t;
-                    new Vector3f(ray.direction).multLocal(distances[1]).addLocal(ray.origin)
+                    Vector3f point0 = new Vector3f(ray.direction).multLocal(distances[0]).addLocal(ray.origin);
-                };
+                    Vector3f point1 = new Vector3f(ray.direction).multLocal(distances[1]).addLocal(ray.origin);
-
+    
-                CollisionResult result = new CollisionResult(points[0], distances[0]);
+                    CollisionResult result = new CollisionResult(point0, distances[0]);
-                results.addCollision(result);
+                    results.addCollision(result);
-                result = new CollisionResult(points[1], distances[1]);
+                    result = new CollisionResult(point1, distances[1]);
+                    results.addCollision(result);
+                    return 2;
+                }
+    
+                Vector3f point = new Vector3f(ray.direction).multLocal(t[0]).addLocal(ray.origin);
+                CollisionResult result = new CollisionResult(point, t[0]);
                 results.addCollision(result);
-                return 2;
+                return 1;
             }
-
+            return 0;
-            Vector3f point = new Vector3f(ray.direction).multLocal(t[0]).addLocal(ray.origin);
+        } finally {
-            CollisionResult result = new CollisionResult(point, t[0]);
+            vars.release();
-            results.addCollision(result);
-            return 1;
         }
-        return 0;
     }
 
     public int collideWith(Collidable other, CollisionResults results) {