sigonasr2/jmonkeyengine
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Changed Camera.setViewPort(float,float,float,float) to not call onViewPortChage 4 times.

Browse Source 
thanks to Lutherion http://jmonkeyengine.org/groups/development-discussion-jme3/forum/topic/possible-bug-with-viewport-on-camera/#post-124630

git-svn-id: https://jmonkeyengine.googlecode.com/svn/trunk@7235 75d07b2b-3a1a-0410-a2c5-0572b91ccdca
This commit is contained in:
rem..om 2011-04-12 11:29:56 +00:00
parent 7d09cafa71
commit 14e4b79170
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
engine/src/core/com/jme3/renderer/Camera.java
View File

@ -207,7 +207,6 @@ public class Camera implements Savable, Cloneable {
protected Matrix4f projectionMatrix = new Matrix4f();
protected Matrix4f viewProjectionMatrix = new Matrix4f();
private BoundingBox guiBounding = new BoundingBox();
/** The camera's name. */
protected String name;
@ -913,10 +912,11 @@ public class Camera implements Savable, Cloneable {
* @param top the top boundary of the viewport (default: 1)
*/
public void setViewPort(float left, float right, float bottom, float top) {
setViewPortLeft(left);
setViewPortRight(right);
setViewPortBottom(bottom);
setViewPortTop(top);
this.viewPortLeft = left;
this.viewPortRight = right;
this.viewPortBottom = bottom;
this.viewPortTop = top;
onViewPortChange();
}
/**
@ -983,7 +983,7 @@ public class Camera implements Savable, Cloneable {
return rVal;
}
public boolean containsGui(BoundingVolume bound) {
return guiBounding.intersects(bound);
}
@ -1069,15 +1069,15 @@ public class Camera implements Savable, Cloneable {
viewportChanged = true;
setGuiBounding();
}
private void setGuiBounding() {
float sx = width*viewPortLeft;
float ex = width*viewPortRight;
float sy = height*viewPortBottom;
float ey = height*viewPortTop;
float xExtent = (ex-sx)/2;
float yExtent = (ey-sy)/2;
guiBounding.setCenter(new Vector3f(sx+xExtent, sy+yExtent, 0));
float sx = width * viewPortLeft;
float ex = width * viewPortRight;
float sy = height * viewPortBottom;
float ey = height * viewPortTop;
float xExtent = (ex - sx) / 2;
float yExtent = (ey - sy) / 2;
guiBounding.setCenter(new Vector3f(sx + xExtent, sy + yExtent, 0));
guiBounding.setXExtent(xExtent);
guiBounding.setYExtent(yExtent);
guiBounding.setZExtent(Float.MAX_VALUE);