sigonasr2/SkillDisplay
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #1 from Jessidhia/patch-1

Browse Source 
Refactor Action.js
This commit is contained in:
Rawrington 2019-07-10 11:30:47 +01:00 committed by GitHub
commit 7895003b44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 40 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
src/Action.js
View File

@ -1,7 +1,7 @@
import React from 'react' import React from 'react'
import './css/Action.css' import './css/Action.css'
const gcdExceptions = [ const gcdOverrides = new Set([
15997, //standard step 15997, //standard step
15998, //technical step 15998, //technical step
15999, 15999,
@ -18,47 +18,50 @@ const gcdExceptions = [
16196, //quadruple technical finish 16196, //quadruple technical finish
7418, //flamethrower 7418, //flamethrower
16483 //tsubame-gaeshi 16483 //tsubame-gaeshi
] ])
const ogcdExceptions = [ const ogcdOverrides = new Set([
3559, //bard WM 3559, //bard WM
116, //bard AP 116, //bard AP
114 //bard MB 114 //bard MB
] ])
class Action extends React.Component { export default function Action({ action_id }) {
state = { const [apiData, setApiData] = React.useState()
xivapi_data: []
}
constructor(props) { React.useEffect(() => {
super(props); let current = true
void (async () => {
const data = await (
await fetch(`https://xivapi.com/Action/${action_id}`, { mode: 'cors' })
).json()
if (current) {
setApiData(data)
}
})()
const actionUrl = "https://xivapi.com/Action/"+props.action_id; return () => {
current = false
fetch(actionUrl, { mode: 'cors' })
.then(response => response.json())
.then(data => {this.setState({xivapi_data: data})})
}
isGCD() {
if(ogcdExceptions.indexOf(this.props.action_id) !== -1) return false
if(gcdExceptions.indexOf(this.props.action_id) !== -1) return true
return (this.state.xivapi_data.ActionCategory.ID !== 4)
}
render() {
if(this.state.xivapi_data.Icon) {
const classes = this.isGCD()?'action-icon gcd':'action-icon ogcd'
const img = "https://xivapi.com"+this.state.xivapi_data.Icon
return <img className={classes} src={img} alt='' />
} }
else }, [action_id])
{
return null const isGCD = React.useMemo(
} () =>
} gcdOverrides.has(action_id) ||
!ogcdOverrides.has(action_id) ||
apiData !== undefined && apiData.ActionCategory.ID !== 4,
[action_id]
)
if (apiData === undefined || !apiData.Icon) {
return null
}
return (
<img
className={isGCD ? 'action-icon gcd' : 'action-icon ogcd'}
src={`https://xivapi.com/${apiData.Icon}`}
alt={apiData.Name || ''}
/>
)
} }
export default Action