From bbb49b6ae42d74f5e416cde9351bd09b3897bf22 Mon Sep 17 00:00:00 2001
From: Glenn Maynard <glenn@steprevolution.com>
Date: Sat, 14 Sep 2019 21:18:42 -0500
Subject: [PATCH] Show a warning if the low FSR threshold is set too low.

---
 smx-config/MainWindow.xaml                 |  15 ++++++++++++++-
 smx-config/MainWindow.xaml.cs              |  13 +++++++++++++
 smx-config/Resources/threshold_warning.png | Bin 0 -> 2515 bytes
 smx-config/SMX.cs                          |  18 ++++++++++++++++++
 smx-config/SMXConfig.csproj                |   3 +++
 smx-config/Widgets.cs                      |   6 ++++++
 6 files changed, 54 insertions(+), 1 deletion(-)
 create mode 100644 smx-config/Resources/threshold_warning.png

diff --git a/smx-config/MainWindow.xaml b/smx-config/MainWindow.xaml
index 381c6d9..c599008 100644
--- a/smx-config/MainWindow.xaml
+++ b/smx-config/MainWindow.xaml
@@ -145,8 +145,13 @@ Use if the platform is too sensitive.</clr:String>
                             <Label Margin="5,0,0,0" x:Name="LowerValue" Content="0" Width="30" HorizontalContentAlignment="Right"
                                    HorizontalAlignment="Left" VerticalAlignment="Top"
                             />
+                            <Image x:Name="ThresholdWarning"
+                                   Source="Resources/threshold_warning.png" Width="9" Height="28"
+                                   Margin="10,0,0,0"
+                                   Visibility="Visible"
+                                />
                             <controls:DoubleSlider x:Name="Slider"
-                                Margin="32,5,0,0"
+                                Margin="24,5,0,0"
                                 MinimumDistance="10"
                                 LowerValue="20" UpperValue="35"
                                 VerticalAlignment="Top"
@@ -854,6 +859,14 @@ a panel to activate and deactivate.
                             
 A panel will activate when it reaches the right side of the
 slider, and deactivate when it reaches the left side of the slider.</TextBlock>
+                        <TextBlock x:Name="ThresholdWarningText" DockPanel.Dock="Top" HorizontalAlignment="Center" Margin="0,15,0,0"
+                                   xml:space="preserve"
+                                   TextAlignment="Center"
+                                   Foreground="#F00"
+>Low thresholds above 140 are recommended.  Higher thresholds allow the
+panel to detect releases more quickly.
+                        </TextBlock>
+
 
                         <DockPanel DockPanel.Dock="Bottom"
                                     VerticalAlignment="Bottom" HorizontalAlignment="Stretch" Margin="0,0,5,0">
diff --git a/smx-config/MainWindow.xaml.cs b/smx-config/MainWindow.xaml.cs
index 40108df..c980c4e 100644
--- a/smx-config/MainWindow.xaml.cs
+++ b/smx-config/MainWindow.xaml.cs
@@ -182,6 +182,19 @@ namespace smx_config
             RefreshUploadPadText(args);
             RefreshSelectedColorPicker();
 
+            // Show the threshold warning explanation if any panels are showing the threshold warning icon.
+            bool ShowThresholdWarningText = false;
+            foreach(Tuple<int, SMX.SMXConfig> activePad in ActivePad.ActivePads())
+            {
+                SMX.SMXConfig config = activePad.Item2;
+                for(int panelIdx = 0; panelIdx < 9; ++panelIdx)
+                {
+                    if(config.ShowThresholdWarning(panelIdx))
+                        ShowThresholdWarningText = true;
+                }
+            }
+            ThresholdWarningText.Visibility = ShowThresholdWarningText? Visibility.Visible : Visibility.Hidden;
+
             // If a second controller has connected and we're on Both, see if we need to prompt
             // to sync configs.  We only actually need to do this if a controller just connected.
             if(args.ConfigurationChanged)
diff --git a/smx-config/Resources/threshold_warning.png b/smx-config/Resources/threshold_warning.png
new file mode 100644
index 0000000000000000000000000000000000000000..94c2525345117a6eff1f59950f80a0e16c7b37a0
GIT binary patch
literal 2515
zcmcImU1%It6y64vv=}SeClNZCfEexFnL9iGbQ_c1v{}ujX|mEpD0pY?o!ucjKh8|D
zn>+<Af`X!=)POz+76oZv1Ory|QShM;6%<5i@IhbHJSZXv;=QxK2}z8C3$rtG&UerG
z&bjBDxi8GloEtj!z_CmwGgO)?&e8i(dObLJ7ybY6#W!>&2&Wd~OeQ<Rt|QH>V=I}=
z;ID3FAz3I-n|9!35e_VpZF(U^XELY9njx~6NWxj9>iT(p`^INH=i)qnQ7Mb%us~|=
z)LKO5*JdjA+LCQxe(Vf)x@l4a9!U__^y+?WHuHRH*QC!(Ebv?kNtW{bICID?lxMj@
z5D`wvs=$V_!f8epsyW#(PH~b5bwShxm;+EXWzm!*uKnYww+K7tT=8t%7k$g~wIm5m
zL1;7@*+woKL{$MAh9QWOAW48CK)mWFs0sXdq+_8-Vmorf#0`9oSwvQ_oaA}Rv=xFE
zcFp>6J54lULKB4o%!(|e4zOH480vXlbev4CP%mx1dm4@_t058QNE|FjHkn)@elpT=
zhVAa!a5<`{kz!jQb>dN2Oo_p+tFRU%L0k*=iKDCD5l!Mcy>#xN$22>jr0MPhWtuKD
zGz$?yNf1?npx)X3*$y|ZP+;4waSvZ~eH=96Q5I@@4Jo38<aw%B0hB-vR-kT*kX8f`
zRZ|pO&@wGBj1trZ8$dJwOu>?D(q~cWfdlM1tA~M>%Vx=s6Xe^ZRLt{~RMvH|sp*oU
zA&CG7sWOmk83J8X72sG%6=ek>l56pz>x+TC%=U$?Z}kHXY-*#MdecDIktE9ony4e-
zII;r_oU;J4mBUa{kz=J%QfucUm$oFT_giJGFtrF(qUbip03!(kB*}!b(llTx(6A7J
zx}rHehi%gdA`j65bUjohLg-g{uE(Yj)PtxTV4Cw>zr0i^%tnFZ)~O<%J2%0VCJQPw
zR24{B$aAbR7&{s%V(paYJHiE4#r5TuFej!z0kT_r)#5(^dip1Qm-3c)j#ZbLQk|!>
zic+H9QrWEAB=v=&OH&@FG$g%Wv$#{k#+Db-yiU0>t<Kf<V3{Y+w4drOmv*a(>{b9a
zt7C%sw%FaHIu5rFEwhapp{Y8cxLdF|aFPa!$at0J_b~k<?8iSwD+jYTWL*<&O9RkA
z5MW1^fnhinuyqVARn#q2RXfrDU+mk-wQI<)68hZ{`2QZy;d*t~ZtOQb{>5$>{nM<q
zZdW`4`{J}pP1s$9y?(5aW-^UdNffuYbOKd-o7=;sm>J~JUKsB0+f>esFgZ(O>b7M>
z=q=yjrYG*qnQ=M+S%>UJ;>_M-O%roabg&3)$5QAhCMvKjA_1gWx|$PpM@P6trta=b
zYcKz40DWKX&SH8TV2|B%2z}|EWQb48D5B?-%BitBJ>xuIDvnq5m#)2bVQ5{vySP0#
z@XGp$*@0V+9o@>jwYBw!_2|&$@sHj;>D~V2<EyV<-kksBzT3mm!07#7zJ2TaJAOZL
z<L4izjdzqgzqu6r<y|@c)XC8j%xt`W(-i(Je(~)O?`=GOWwUYb{8!o|ujbcp{&sfi
wxy=ub$PXQV;?3>PuYLE^+VJ_cOP_AsbKzyx`Z{tp*s-fLIa9no@$|EQ1Dee&O#lD@

literal 0
HcmV?d00001

diff --git a/smx-config/SMX.cs b/smx-config/SMX.cs
index ea03b05..58ff795 100644
--- a/smx-config/SMX.cs
+++ b/smx-config/SMX.cs
@@ -112,6 +112,24 @@ namespace SMX
             return masterVersion >= 4 && (configFlags & SMXConfigFlags.PlatformFlags_FSR) != 0;
         }
 
+        // Return true if the low threshold is set too low.
+        //
+        // Higher low threshold values make the panel respond to the panel being released more
+        // quickly.  It shouldn't be set too low.
+        public bool ShowThresholdWarning(int panel)
+        {
+            if(!fsr())
+                return false;
+
+            // Don't show warnings for disabled panels.
+            if(!GetEnabledPanels()[panel])
+                return false;
+
+            int lower = panelSettings[panel].fsrLowThreshold[0];
+            int MinimumRecommendedLowThreshold = 140;
+            return lower < MinimumRecommendedLowThreshold;
+        }
+
         // enabledSensors is a mask of which panels are enabled.  Return this as an array
         // for convenience.
         public bool[] GetEnabledPanels()
diff --git a/smx-config/SMXConfig.csproj b/smx-config/SMXConfig.csproj
index 6905af4..96f395d 100644
--- a/smx-config/SMXConfig.csproj
+++ b/smx-config/SMXConfig.csproj
@@ -218,6 +218,9 @@
     <Resource Include="Resources\sensor_right.png" />
     <Resource Include="Resources\sensor_up.png" />
   </ItemGroup>
+  <ItemGroup>
+    <Resource Include="Resources\threshold_warning.png" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.
diff --git a/smx-config/Widgets.cs b/smx-config/Widgets.cs
index ef4b6fa..1348bfd 100644
--- a/smx-config/Widgets.cs
+++ b/smx-config/Widgets.cs
@@ -122,6 +122,7 @@ namespace smx_config
 
         DoubleSlider slider;
         Label LowerLabel, UpperLabel;
+        Image ThresholdWarning;
 
         OnConfigChange onConfigChange;
 
@@ -132,6 +133,7 @@ namespace smx_config
             slider = GetTemplateChild("Slider") as DoubleSlider;
             LowerLabel = GetTemplateChild("LowerValue") as Label;
             UpperLabel = GetTemplateChild("UpperValue") as Label;
+            ThresholdWarning = GetTemplateChild("ThresholdWarning") as Image;
 
             slider.ValueChanged += delegate(DoubleSlider slider) { SaveToConfig(); };
 
@@ -249,6 +251,10 @@ namespace smx_config
                 UpperLabel.Content = upper.ToString();
             }
 
+            int panelIdx = panelNameToIndex[Type];
+            bool ShowThresholdWarning = config.ShowThresholdWarning(panelIdx);
+            ThresholdWarning.Visibility = ShowThresholdWarning? Visibility.Visible:Visibility.Hidden;
+
             RefreshVisibility();
             UpdatingUI = false;
         }