sigonasr2/AdventuresInLestoria
1
1
Fork 0
Code Issues 20 Pull Requests 1 Actions Projects 1 Releases Wiki Activity

Consistent class usage for AbilitySlot enum #93

New Issue
Closed
opened 2025-08-01 13:59:05 -05:00 by sigonasr2 · 3 comments
sigonasr2 commented 2025-08-01 13:59:05 -05:00
Owner
Copy Link

Consider converting other uses of this enum class in the project to use specifically this one.

Originally posted by @sigonasr2 in http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/pulls/92/files#issuecomment-1734

Consider converting other uses of this enum class in the project to use specifically this one. _Originally posted by @sigonasr2 in http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/pulls/92/files#issuecomment-1734_
sigonasr2 added reference SkillMenu 2025-08-01 13:59:16 -05:00
sigonasr2 added a new dependency 2025-08-01 14:00:12 -05:00
#92 SkillMenu
sigonasr2 commented 2025-08-01 14:00:55 -05:00
Author
Owner
Copy Link

Required to complete PR #92

Required to complete PR #92
sigonasr2 commented 2025-08-01 14:03:24 -05:00
Author
Owner
Copy Link

ItemEnchantInfo::AbilitySlot has an entirely different purpose focused around enchanting. Perhaps a rename instead would clear up confusion. They need to remain separate.

`ItemEnchantInfo::AbilitySlot` has an entirely different purpose focused around enchanting. Perhaps a rename instead would clear up confusion. They need to remain separate.
sigonasr2 commented 2025-08-01 14:14:26 -05:00
Author
Owner
Copy Link

Fixed in commit 4d2eb86efe

Fixed in commit `4d2eb86efe`
Sign in to join this conversation.
SkillMenu
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
major
An important feature that is missing from the spec.
minor
Something that needs to be done but isn't time-sensitive or necessarily important to the overall spec.
missing
A feature is missing.
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Quapsel sigonasr2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#92 SkillMenu
sigonasr2/AdventuresInLestoria
Reference: sigonasr2/AdventuresInLestoria#93
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?