I'm not convinced that file hashes will work if the coincidental hash ends up with two \ characters in a row or if \n appears between loading and saving. Calling GetString() will convert \ + \n contiguous sequences into one newline character yet the generated hash from GetHash() does not generate newlines...
More research required.
http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/src/commit/d0db3412d914d81fb4134816eb0c010f57f7a643/Adventures%20in%20Lestoria/SaveFile.cpp#L225
I'm not convinced that file hashes will work if the coincidental hash ends up with two `\` characters in a row or if `\n` appears between loading and saving. Calling `GetString()` will convert `\` + `\n` contiguous sequences into one newline character yet the generated hash from `GetHash()` does not generate newlines...
More research required.
d0db3412d9/Adventures%20in%20Lestoria/SaveFile.cpp (L225)
I'm not convinced that file hashes will work if the coincidental hash ends up with two
\
characters in a row or if\n
appears between loading and saving. CallingGetString()
will convert\
+\n
contiguous sequences into one newline character yet the generated hash fromGetHash()
does not generate newlines...More research required.
Removing the hashing function. It's kinda pointless and this is a single player game.. Why do we care.