Analyze new-line escaping in File Hashes #68

Closed
opened 2 months ago by sigonasr2 · 1 comments
Owner

d0db3412d9/Adventures%20in%20Lestoria/SaveFile.cpp (L225)

I'm not convinced that file hashes will work if the coincidental hash ends up with two \ characters in a row or if \n appears between loading and saving. Calling GetString() will convert \ + \n contiguous sequences into one newline character yet the generated hash from GetHash() does not generate newlines...

More research required.

http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/src/commit/d0db3412d914d81fb4134816eb0c010f57f7a643/Adventures%20in%20Lestoria/SaveFile.cpp#L225 I'm not convinced that file hashes will work if the coincidental hash ends up with two `\` characters in a row or if `\n` appears between loading and saving. Calling `GetString()` will convert `\` + `\n` contiguous sequences into one newline character yet the generated hash from `GetHash()` does not generate newlines... More research required.
sigonasr2 added the
major
question
labels 2 months ago
sigonasr2 self-assigned this 2 months ago
sigonasr2 added the
wontfix
label 2 months ago
Poster
Owner

Removing the hashing function. It's kinda pointless and this is a single player game.. Why do we care.

Removing the hashing function. It's kinda pointless and this is a single player game.. Why do we care.
sigonasr2 closed this issue 2 months ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sigonasr2/AdventuresInLestoria#68
Loading…
There is no content yet.