sigonasr2
/
AdventuresInLestoria
1
1
Fork 0
Code Issues 9 Pull Requests Projects 1 Releases Wiki Activity
Labels Milestones

audio-buffer-through-resource-pack #65

Merged
sigonasr2 merged 2 commits from audio-buffer-through-resource-pack into master 3 months ago
Conversation 1 Commits 2 Files Changed 15
sigonasr2 commented 3 months ago
Owner

This PR adds the ability for BGM tracks to be encrypted away inside the PGE resource pack system such that it will be more difficult for users to extract the songs from the game.

Because of this, we load the tracks in memory now reading directly from a buffer. (Luckily miniaudio makes this really easy to tack onto the existing pipeline)

Another additional change had to be made with manual loading of sounds. If we want to store a sound ID and track it ourselves, we are now required to specify it's a sound effect to prevent it from getting read as a resource pack item.

This PR adds the ability for BGM tracks to be encrypted away inside the PGE resource pack system such that it will be more difficult for users to extract the songs from the game. Because of this, we load the tracks in memory now reading directly from a buffer. (Luckily miniaudio makes this really easy to tack onto the existing pipeline) Another additional change had to be made with manual loading of sounds. If we want to store a sound ID and track it ourselves, we are now required to specify it's a sound effect to prevent it from getting read as a resource pack item.
sigonasr2 added the
enhancement
 label 3 months ago
sigonasr2 self-assigned this 3 months ago
sigonasr2 added 2 commits 3 months ago
sigonasr2 merged commit ce1caabc90 into master 3 months ago
sigonasr2 deleted branch audio-buffer-through-resource-pack 3 months ago
sigonasr2 commented 3 months ago
Poster
Owner

As an addendum, how to accomplish this came from https://github.com/mackron/miniaudio/discussions/426

As an addendum, how to accomplish this came from https://github.com/mackron/miniaudio/discussions/426
The pull request has been merged as ce1caabc90.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong major
An important feature that is missing from the spec. minor
Something that needs to be done but isn't time-sensitive or necessarily important to the overall spec. missing
A feature is missing. question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid major minor missing question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
sigonasr2
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sigonasr2/AdventuresInLestoria#65
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'audio-buffer-through-resource-pack'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes