Linux Build Input Helper Text Flips Order Rapidly & Often #60

New Issue

sigonasr2 · 2024-06-18T12:50:38-05:00

sigonasr2 commented

2024-06-18 12:50:38 -05:00

When playing on the Linux build of the game, the input helper text that shows what keys to press and what their functions are will randomly and rapidly change order. They seem to stabilize when the game is not doing as much.

This is likely due to key sorting (using pointers to sort perhaps?)

Applies to demo build and current dev build.

When playing on the Linux build of the game, the input helper text that shows what keys to press and what their functions are will randomly and rapidly change order. They seem to stabilize when the game is not doing as much. This is likely due to key sorting (using pointers to sort perhaps?) Applies to demo build and current dev build.

sigonasr2 added this to the Chapter 2 Complete milestone 2024-06-18 12:50:38 -05:00

sigonasr2 added the

bug

major

labels 2024-06-18 12:50:38 -05:00

sigonasr2 self-assigned this 2024-06-18 12:50:38 -05:00

sigonasr2 removed reference master

2024-06-18 12:50:41 -05:00

sigonasr2 commented

2024-06-18 12:54:35 -05:00

When playing on the Linux build of the game, the input helper text that shows what keys to press and what their functions are will randomly and rapidly change order. They seem to stabilize when the game is not doing as much.

This is likely due to key sorting (using pointers to sort perhaps?)

Applies to demo build and current dev build.

Indeed the InputGroup and InputEngageGroup classes use pointer sorts. Yuck.

http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/src/branch/master/Adventures%20in%20Lestoria/Key.cpp#L1146

http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/src/branch/master/Adventures%20in%20Lestoria/Key.cpp#L1150

Create well-defined sorting behaviors for these two classes to resolve this Issue.

> When playing on the Linux build of the game, the input helper text that shows what keys to press and what their functions are will randomly and rapidly change order. They seem to stabilize when the game is not doing as much. > > This is likely due to key sorting (using pointers to sort perhaps?) > > Applies to demo build and current dev build. Indeed the `InputGroup` and `InputEngageGroup` classes use pointer sorts. Yuck. http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/src/branch/master/Adventures%20in%20Lestoria/Key.cpp#L1146 http://sig.projectdivar.com/sigonasr2/AdventuresInLestoria/src/branch/master/Adventures%20in%20Lestoria/Key.cpp#L1150 Create well-defined sorting behaviors for these two classes to resolve this Issue.

sigonasr2 commented

2024-06-18 15:58:12 -05:00

Resolved in commit c83aff8962.

The result is slightly ugly though... Consider refactoring Input Keybind helper system to maintain ordering of inserted keys...

Resolved in commit c83aff8962. The result is slightly ugly though... Consider refactoring Input Keybind helper system to maintain ordering of inserted keys...

sigonasr2 closed this issue

2024-06-18 15:58:12 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sigonasr2/AdventuresInLestoria#60