sigonasr2/AdventuresInLestoria
1
1
Fork 0
Code Issues 11 Pull Requests Actions Projects 1 Releases Wiki Activity

Emscripten/Linux Build Spawn List Missing #32

New Issue
Closed
opened 2024-01-16 22:35:42 -06:00 by sigonasr2 · 1 comment
sigonasr2 commented 2024-01-16 22:35:42 -06:00
Owner
Copy Link

The spawn lists for the emscripten and Linux builds of the game do not populate correctly for some bizarre reason. Need to debug on clang/gcc...

The spawn lists for the emscripten and Linux builds of the game do not populate correctly for some bizarre reason. Need to debug on clang/gcc...
sigonasr2 added the
bug
 label 2024-01-16 22:35:42 -06:00
sigonasr2 self-assigned this 2024-01-16 22:35:42 -06:00
sigonasr2 commented 2024-01-17 09:47:18 -06:00
Author
Owner
Copy Link

This issue was caused by the different ordering implementation for std::set iterators. On Windows, the set is ordered by insertion order while on Emscripten/Linux the iterators are sorted by name. In this scenario, the WORLD_MAP entry would load last, which had all connection points.

While this meant we had all connection points when loading all other levels, it also meant on the Linux/Emscripten build all other levels would be loaded first, and this means no connection points were updated correctly.

Deffering the connection point reading code until after all levels were loaded was the correct solution here.

This issue was caused by the different ordering implementation for `std::set` iterators. On Windows, the set is ordered by insertion order while on Emscripten/Linux the iterators are sorted by name. In this scenario, the `WORLD_MAP` entry would load last, which had all connection points. While this meant we had all connection points when loading all other levels, it also meant on the Linux/Emscripten build all other levels would be loaded first, and this means no connection points were updated correctly. Deffering the connection point reading code until after all levels were loaded was the correct solution here.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
major
An important feature that is missing from the spec.
minor
Something that needs to be done but isn't time-sensitive or necessarily important to the overall spec.
missing
A feature is missing.
question
More information is needed
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Quapsel sigonasr2
No Assignees sigonasr2
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigonasr2/AdventuresInLestoria#32
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?