sigonasr2/AdventuresInLestoria
1
1
Fork 0
Code Issues 20 Pull Requests 1 Actions Projects 1 Releases Wiki Activity

TODO: Convert Menu Components to Smart Pointers #20

New Issue
Closed
opened 2023-10-22 23:20:18 -05:00 by sigonasr2 · 3 comments
sigonasr2 commented 2023-10-22 23:20:18 -05:00
Owner
Copy Link

Because I have way too many raw pointer containers for this.

Because I have way too many raw pointer containers for this.
sigonasr2 added the
major
 label 2023-10-22 23:20:18 -05:00
sigonasr2 added the
wontfix
 label 2024-01-08 11:47:26 -06:00
sigonasr2 removed the
wontfix
 label 2024-01-15 17:56:38 -06:00
sigonasr2 commented 2024-01-15 17:57:03 -06:00
Author
Owner
Copy Link

Decided to implement it during the gamepad menu navigation implementation.

Gigantic refactor incoming.

Decided to implement it during the gamepad menu navigation implementation. Gigantic refactor incoming.
sigonasr2 commented 2024-01-16 08:37:31 -06:00
Author
Owner
Copy Link

Templated version of custom dynamic pointer casts with potential error handling for wrong type casting:

template<typename T,typename U>
std::shared_ptr<T>DYNAMIC_POINTER_CAST(const std::shared_ptr<U>&variable){
    std::shared_ptr<T> newVariable=std::dynamic_pointer_cast<T>(variable);
    if(!newVariable)std::cout<<"Could not cast!"<<std::endl;
    return newVariable;
}

template<typename T,typename U>
std::shared_ptr<T>DYNAMIC_POINTER_CAST(const std::weak_ptr<U>&variable){
    std::shared_ptr<T> newVariable=std::dynamic_pointer_cast<T>(variable.lock());
    if(!newVariable)std::cout<<"Could not cast!"<<std::endl;
    return newVariable;
}
Templated version of custom dynamic pointer casts with potential error handling for wrong type casting: ```cpp template<typename T,typename U> std::shared_ptr<T>DYNAMIC_POINTER_CAST(const std::shared_ptr<U>&variable){ std::shared_ptr<T> newVariable=std::dynamic_pointer_cast<T>(variable); if(!newVariable)std::cout<<"Could not cast!"<<std::endl; return newVariable; } template<typename T,typename U> std::shared_ptr<T>DYNAMIC_POINTER_CAST(const std::weak_ptr<U>&variable){ std::shared_ptr<T> newVariable=std::dynamic_pointer_cast<T>(variable.lock()); if(!newVariable)std::cout<<"Could not cast!"<<std::endl; return newVariable; } ```
sigonasr2 commented 2024-01-16 17:31:35 -06:00
Author
Owner
Copy Link

Resolved in pull request #30.

Resolved in pull request #30.
sigonasr2 added the
enhancement
 label 2024-01-16 17:31:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
major
An important feature that is missing from the spec.
minor
Something that needs to be done but isn't time-sensitive or necessarily important to the overall spec.
missing
A feature is missing.
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
major
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Quapsel sigonasr2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigonasr2/AdventuresInLestoria#20
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?